AI-849: Fixes FROM formatting

Vastra-Gotalandsregionen · Mar 17, 2023 · f6f8716 · f6f8716
1 parent 7aaa238
commit f6f8716
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/tests/test_pytorch_env.py b/tests/test_pytorch_env.py
@@ -87,7 +87,7 @@ def test_dockerfile(self):
             lines = list(map(lambda x: x.strip(), fin.readlines()))
         dockerfile_text = Path(dockerfile_path).read_text()
 
-        assert lines[1] == "FROM registry.git.vgregion.se/aiplattform/images/pytorch:0.3.2"
+        assert lines[0] == "FROM registry.git.vgregion.se/aiplattform/images/pytorch:0.3.2"
         assert lines[-2] == 'WORKDIR /workspace'
         assert "ADD http://aiav2.vgregion.se/VGC%20Root%20CA%20v2.crt /tmp/vgc_root.der" in lines
         assert "ADD http://aiav2.vgregion.se/VGC%20Issuing%201%20CA%20v2.crt /tmp/vgc_issuing1.der" in lines

diff --git a/tests/test_r_env.py b/tests/test_r_env.py
@@ -51,7 +51,7 @@ def test_dockerfile(self):
             lines = list(map(lambda x: x.strip(), fin.readlines()))
         dockerfile_text = Path(dockerfile_path).read_text()
 
-        assert lines[2] == "FROM registry.git.vgregion.se/aiplattform/images/r:0.3.0"
+        assert lines[0] == "FROM registry.git.vgregion.se/aiplattform/images/r:0.3.0"
         assert lines[-5] == 'RUN R -e \'renv::activate()\' && R -e \'renv::restore()\''
         assert lines[-3] == 'USER root'
         assert lines[-2] == 'EXPOSE 8787'

diff --git a/{{ cookiecutter.repo_name }}/Dockerfile b/{{ cookiecutter.repo_name }}/Dockerfile
@@ -1,6 +1,6 @@
-{% if cookiecutter.image == 'Tensorflow' %}FROM registry.git.vgregion.se/aiplattform/images/tensorflow:0.2.1{% endif %}
-{% if cookiecutter.image == 'PyTorch' %}FROM registry.git.vgregion.se/aiplattform/images/pytorch:0.3.2{% endif %}
-{% if cookiecutter.image == 'R' %}FROM registry.git.vgregion.se/aiplattform/images/r:0.3.0{% endif %}
+{% if cookiecutter.image == 'Tensorflow' -%}FROM registry.git.vgregion.se/aiplattform/images/tensorflow:0.2.1
+{% elif cookiecutter.image == 'PyTorch' -%}FROM registry.git.vgregion.se/aiplattform/images/pytorch:0.3.2
+{% elif cookiecutter.image == 'R' -%}FROM registry.git.vgregion.se/aiplattform/images/r:0.3.0{%- endif %}
 ENV GID=1000
 ENV UID=1000
 {% if cookiecutter.image == 'R' %}ENV EDITOR_FOCUS_DIR="/workspace"{% endif %}