Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully translate welcome page on rotation #338

Closed
wants to merge 1 commit into from

Conversation

jardon
Copy link
Member

@jardon jardon commented Sep 30, 2024

  • Translate all text and buttons to rotation on the welcome page

This only partially translates it currently as many of the translations are partially commented out.

@jardon jardon force-pushed the fix/localization branch 2 times, most recently from 3a1c3e6 to 225e932 Compare October 1, 2024 23:34
@mirkobrombin
Copy link
Member

I am not sure that everything should change in that view. The purpose of the welcome rotating language is purely visual, translating all the other elements might lead to issues since they change really fast (but even if the were slow).

@jardon
Copy link
Member Author

jardon commented Oct 2, 2024

while youre right that change is unnecessary, I personally think localization should better supported. ideally, the language would already be set correct by default. so the buttons were readable. I'll close this and focus on configuring the language from the get-go

@jardon jardon closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants