feat: add OM navigation in the backend #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiipou
commented
Dec 23, 2022
+ fix of `OM1_dist` must be `OM1_value`
shiipou
commented
Dec 24, 2022
| l = 2*(z3 - z2) | ||
|
|
||
| # Solve for x, y, and z using Cramers Rule | ||
| x = (e*l*b - f*k*b - e*i*c + f*h*c + d*k*c - d*l*a) / (d*k*i - d*l*h - e*j*i + e*l*g + f*j*h - f*k*g) |
There was a problem hiding this comment.
It seems I got divide by zero error here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You'll probably need to use the OM database to get the OM coordinates of the container you use and pass it to the backend using the args I add in this PR.EDIT: doneTell me if anything seems wrong in this PR, I'm not a mathematician so it can be wrong.
I suggest you to do some refactor to split the
backend.pyin multiples files for better readability. It's never a good choice to use a god-file that contain everything.I also suggest you to add some tests using value of your database, if you know X,Y,Z coordinates and can calculate OM distance, etc... you can easily test this function using your database and transformation functions.