fix: Properly close adb and rclone on exit
#35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeRatcliffe
force-pushed
the
ensure-sidenoder-closes-adb-and-rclone
branch
from
8bb462f to
52f988a
Compare
MikeRatcliffe
force-pushed
the
ensure-sidenoder-closes-adb-and-rclone
branch
from
52f988a to
d005071
Compare
MikeRatcliffe
force-pushed
the
ensure-sidenoder-closes-adb-and-rclone
branch
from
d005071 to
419e05b
Compare
fix: Battery not displayed properly build: Add eslint
MikeRatcliffe
force-pushed
the
ensure-sidenoder-closes-adb-and-rclone
branch
from
419e05b to
4900500
Compare
MikeRatcliffe
force-pushed
the
ensure-sidenoder-closes-adb-and-rclone
branch
2 times, most recently
from
2032a7a to
4cf6643
Compare
MikeRatcliffe
force-pushed
the
ensure-sidenoder-closes-adb-and-rclone
branch
from
4cf6643 to
9328520
Compare
Adds GitHub Actions workflow for automated releases, including:
- Build for multiple OSs:
- macOs (Universal `dmg` for both Intel & M1)
- Windows `exe`
- Linux:
- `AppImage`
- `deb`
- `rpm`
- Changelog is automatically generated when a version number tag is added to a commit e.g. `v0.9.2`.
This streamlines the release process and ensures consistent releases across all platforms.
Usage:
1. Update version number in `package.json`.
2. ```
git commit -m "Release v0.9.2"
git tag v0.9.2 # The version number must be in the format `v1.2.3`.
git push --force --tags
```
3. That's it... a release will be automatically generated along with conventional commit messages and installation packages for each platform.
To ensure we pick up all changes we should probably add the conventional commits pre-commit hook to ensure commit messages contain the required `fix`, `feat` etc.
MikeRatcliffe
force-pushed
the
ensure-sidenoder-closes-adb-and-rclone
branch
from
9328520 to
0289896
Compare
fix: Properly close `adb` and `rclone` on exit Fixes VRPirates#34 Cleanly closes `adb` and `rclone` connections when the application exits, ensuring resources are freed and preventing potential issues. This addresses a previous oversight where these connections weren't properly closed, potentially leading to resource leaks or unexpected behavior. Even though we free up the adb connection we don't close the server because other programs may be using the connection.
MikeRatcliffe
force-pushed
the
ensure-sidenoder-closes-adb-and-rclone
branch
from
0289896 to
6207d21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
Cleanly closes
adbandrcloneconnections when the application exits, ensuring resources are freed and preventing potential issues. This addresses a previous oversight where these connections weren't properly closed, potentially leading to resource leaks or unexpected behavior.Even though we free up the adb connection we don't close the server because other programs may be using the connection.