Ensure that Sidenoder closes adb and rclone
#34
Comments
MikeRatcliffe
added a commit
to MikeRatcliffe/sidenoder
that referenced
this issue
Sep 14, 2024
Fixes VRPirates#34 Cleanly closes `adb` and `rclone` connections when the application exits, ensuring resources are freed and preventing potential issues. This addresses a previous oversight where these connections weren't properly closed, potentially leading to resource leaks or unexpected behavior. Even though we free up the adb connection we don't close the server because other programs may be using the connection.
MikeRatcliffe
added a commit
to MikeRatcliffe/sidenoder
that referenced
this issue
Sep 17, 2024
Fixes VRPirates#34 Cleanly closes `adb` and `rclone` connections when the application exits, ensuring resources are freed and preventing potential issues. This addresses a previous oversight where these connections weren't properly closed, potentially leading to resource leaks or unexpected behavior. Even though we free up the adb connection we don't close the server because other programs may be using the connection.
MikeRatcliffe
added a commit
to MikeRatcliffe/sidenoder
that referenced
this issue
Sep 17, 2024
fix: Properly close `adb` and `rclone` on exit Fixes VRPirates#34 Cleanly closes `adb` and `rclone` connections when the application exits, ensuring resources are freed and preventing potential issues. This addresses a previous oversight where these connections weren't properly closed, potentially leading to resource leaks or unexpected behavior. Even though we free up the adb connection we don't close the server because other programs may be using the connection.
MikeRatcliffe
added a commit
to MikeRatcliffe/sidenoder
that referenced
this issue
Sep 18, 2024
Fixes VRPirates#34 Cleanly closes `adb` and `rclone` connections when the application exits, ensuring resources are freed and preventing potential issues. This addresses a previous oversight where these connections weren't properly closed, potentially leading to resource leaks or unexpected behavior. Even though we free up the adb connection we don't close the server because other programs may be using the connection.
This was referenced Sep 18, 2024
MikeRatcliffe
added a commit
to MikeRatcliffe/sidenoder
that referenced
this issue
Sep 30, 2024
Fixes VRPirates#34 Cleanly closes `adb` and `rclone` connections when the application exits, ensuring resources are freed and preventing potential issues. This addresses a previous oversight where these connections weren't properly closed, potentially leading to resource leaks and unexpected behavior. Even though we free up the adb connection we don't close the server because other programs may be using the connection. The changes introduce a `destroy()` function in `tools.js` that handles the cleanup. This function is called when the application receives the "will-quit" event, ensuring that resources are freed before the application terminates. This change enhances the application's reliability and stability by preventing resource leaks and ensuring a clean exit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sidenoder has a tendency to leave
adbandrcloneopen when it's closed.We need to close them when Sidenoder is closed.
The text was updated successfully, but these errors were encountered: