Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPLライセンス違反確認を追加しました。 #1141

Merged
merged 9 commits into from
Mar 29, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented Mar 25, 2024

(PR #679 引き継ぎ from tuna2134 by tarepan)

内容

GPLライセンス違反を確認する機能を追加しました。

関連 Issue

close #546

@tarepan tarepan requested a review from a team as a code owner March 25, 2024 10:36
@tarepan tarepan requested review from Hiroshiba and removed request for a team March 25, 2024 10:36
Copy link

github-actions bot commented Mar 25, 2024

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 517 210 coverage-59%
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/cancellable_engine.py 94 72 coverage-23%
voicevox_engine/core/init.py 0 0 coverage-100%
voicevox_engine/core/core_adapter.py 81 6 coverage-93%
voicevox_engine/core/core_initializer.py 60 30 coverage-50%
voicevox_engine/core/core_wrapper.py 225 157 coverage-30%
voicevox_engine/dev/init.py 0 0 coverage-100%
voicevox_engine/dev/core/init.py 0 0 coverage-100%
voicevox_engine/dev/core/mock.py 65 2 coverage-97%
voicevox_engine/dev/tts_engine/init.py 0 0 coverage-100%
voicevox_engine/dev/tts_engine/mock.py 28 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifest.py 36 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifestLoader.py 12 0 coverage-100%
voicevox_engine/engine_manifest/init.py 0 0 coverage-100%
voicevox_engine/library_manager.py 92 4 coverage-96%
voicevox_engine/metas/Metas.py 36 0 coverage-100%
voicevox_engine/metas/MetasStore.py 28 1 coverage-96%
voicevox_engine/metas/init.py 0 0 coverage-100%
voicevox_engine/model.py 180 3 coverage-98%
voicevox_engine/morphing.py 71 4 coverage-94%
voicevox_engine/preset/Preset.py 13 0 coverage-100%
voicevox_engine/preset/PresetError.py 2 0 coverage-100%
voicevox_engine/preset/PresetManager.py 80 2 coverage-98%
voicevox_engine/preset/init.py 0 0 coverage-100%
voicevox_engine/setting/Setting.py 9 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 20 0 coverage-100%
voicevox_engine/setting/init.py 0 0 coverage-100%
voicevox_engine/tts_pipeline/init.py 0 0 coverage-100%
voicevox_engine/tts_pipeline/kana_converter.py 88 1 coverage-99%
voicevox_engine/tts_pipeline/mora_mapping.py 7 0 coverage-100%
voicevox_engine/tts_pipeline/phoneme.py 34 0 coverage-100%
voicevox_engine/tts_pipeline/text_analyzer.py 146 6 coverage-96%
voicevox_engine/tts_pipeline/tts_engine.py 267 9 coverage-97%
voicevox_engine/user_dict/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/user_dict/user_dict.py 146 12 coverage-92%
voicevox_engine/utility/init.py 0 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_utility.py 6 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 8 1 coverage-88%
voicevox_engine/utility/mutex_utility.py 13 0 coverage-100%
voicevox_engine/utility/path_utility.py 26 6 coverage-77%
voicevox_engine/utility/run_utility.py 10 7 coverage-30%
TOTAL 2443 533 coverage-78%

@tarepan
Copy link
Contributor Author

tarepan commented Mar 25, 2024

LGPLはOKなので外して頂ければ!
逆にAGPLはv1もv2もたぶんダメなので、含めて頂けると。
Hiroshiba. #679 (comment)

AGPL ですが、AGPL v1/v2 は一般的に「AGPL」と認識されている「GNU AGPL」とは別モノだと理解しています。一例として、AGPL v1 は GPL-imcompatible です (ref)。
なので AGPL v1/v2 はリストに含めなくても実務上問題ないと考えます。

LGPL はおっしゃるとおりです。リストから除外しました。

@Hiroshiba
PR #679 を引き継ぎ、全指摘箇所の反映・テストパスを確認しました。review よろしくお願いします。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

引き継ぎありがとうございます!!
AGPLに関してもありがとうございます。知りませんでした…!

@Hiroshiba Hiroshiba merged commit 473dd9a into VOICEVOX:master Mar 29, 2024
4 checks passed
@tarepan tarepan deleted the patch-2-fork-tarepan branch March 29, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ライブラリ内にGPLなどのライセンスがないか確認するテストを書く
3 participants