Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): 辞書ダイアログの読み方取得ロジックを改善 #2471

Merged
merged 3 commits into from
Jan 4, 2025

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Jan 3, 2025

内容

辞書ダイアログの読み方取得ロジックが若干不安定っぽく、たしかmacOSで不安定だったのでリファクタリングしました。
waitForTimeoutをやめてtoBeVisibleとかを使っています。

関連 Issue

の切り出しです。

スクリーンショット・動画など

その他

@Hiroshiba Hiroshiba requested a review from a team as a code owner January 3, 2025 14:50
@voicevox-preview-pages
Copy link

voicevox-preview-pages bot commented Jan 3, 2025

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:3c0539c

@Hiroshiba Hiroshiba marked this pull request as draft January 3, 2025 14:59
@Hiroshiba Hiroshiba requested a review from Copilot January 3, 2025 15:08

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

tests/e2e/browser/辞書ダイアログ.spec.ts:19

  • Using not.toBeVisible() might lead to flaky tests. Consider using a more deterministic approach to verify the expected behavior, such as waiting for a specific text content or attribute change.
await expect(accentPhrase).not.toBeVisible();

tests/e2e/browser/辞書ダイアログ.spec.ts:25

  • Using not.toHaveCount(0) might lead to flaky tests. Consider using a more deterministic approach to verify the expected behavior, such as waiting for a specific text content or attribute change.
await expect(accentPhrase).not.toHaveCount(0);
@Hiroshiba Hiroshiba marked this pull request as ready for review January 3, 2025 15:27
@Hiroshiba
Copy link
Member Author

まあテスト部分のリファクタリングで大丈夫な気がするのでマージします!

@Hiroshiba Hiroshiba enabled auto-merge January 4, 2025 00:13
@Hiroshiba Hiroshiba added this pull request to the merge queue Jan 4, 2025
Merged via the queue into VOICEVOX:main with commit 4c32048 Jan 4, 2025
11 checks passed
@Hiroshiba Hiroshiba deleted the 20250103-234953 branch January 4, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant