refactor: LOAD_PROJECT_FILEのconfirmがずっと使われてないので消す #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
1 task
Hiroshiba
changed the title
|
たぶん大丈夫だと思うのでマージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
LOAD_PROJECT_FILEのconfirmがずっと使われてないので消しました。無指定の時とtrueのときの動作が同じで、falseのときのみ確認ダイアログを必ず出さないようなロジックになってます。
でもfalseを与えているところが1つもないので、消してしまって大丈夫そうでした。
必要になったら足すのが良さそう（YAGNI原則）
関連 Issue
の解決を行っている時に気づきました
スクリーンショット・動画など
その他