ソング：レンダリング処理をリファクタリング #2429
Merged
ソング：レンダリング処理をリファクタリング #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigprogramming
requested review from
Hiroshiba
and removed request for
a team
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Hiroshiba
approved these changes
Dec 22, 2024
|
マージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#2261 でレンダリングの流れを変更しますが、変更する前に一度リファクタリングを行っておいた方が良さそうなので、リファクタリングを行います。
以下を行います。（分けてコミットしています）
PhraseRenderContextとPhraseRendererを一旦無くすstateにある既存のフレーズをマージphrase.stateの更新searchPhrasesからgeneratePhrasesに変更関連 Issue
その他