Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

アクセントの読み変更時のE2Eテストを追加 #2420

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jdkfx
Copy link
Contributor

@jdkfx jdkfx commented Dec 18, 2024

内容

  • 下記Issueから「アクセント欄の読みの部分をクリックすることで読みを変更できる」を追加

関連 Issue

ref #1462

スクリーンショット・動画など

その他

@@ -34,6 +34,7 @@ test("音声パラメータ引き継ぎの設定", async ({ page }) => {
// パラメータを引き継がないことの確認
await page.locator(".audio-cell input").first().click();
await page.getByRole("button").filter({ hasText: "add" }).click();
await page.waitForTimeout(100);
Copy link
Contributor Author

@jdkfx jdkfx Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

テストを追加したことにより、この処理がないと既存の通っていたテストが通らなくなる。
理由は不明。

  1) [browser] › browser/音声パラメータ.spec.ts:12:5 › 音声パラメータ引き継ぎの設定 ─────────────────────────────────────

    Error: expect(received).toBe(expected) // Object.is equality

    Expected: "1.00"
    Received: "0.50"

       7 | async function validateValue(locator: Locator, expectedValue: string) {
       8 |   const value = await locator.evaluate((e: HTMLInputElement) => e.value);
    >  9 |   expect(value).toBe(expectedValue);
         |                 ^
      10 | }
      11 |
      12 | test("音声パラメータ引き継ぎの設定", async ({ page }) => {

        at validateValue (/Users/jdkfx/Desktop/workspace/voicevox/tests/e2e/browser/音声パラメータ.spec.ts:9:17)
        at /Users/jdkfx/Desktop/workspace/voicevox/tests/e2e/browser/音声パラメータ.spec.ts:37:3

    attachment #1: video (video/webm) ──────────────────────────────────────────────────────────────
    test-results/音声パラメータ-音声パラメータ引き継ぎの設定-browser/video.webm
    ────────────────────────────────────────────────────────────────────────────────────────────────

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flakyになりやすいから、waitForTimeoutではない方法を使った方がいいかも。
https://zenn.dev/cureapp/articles/73cd66a37cc9e8

@voicevox-preview-pages
Copy link

voicevox-preview-pages bot commented Dec 18, 2024

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:6891dcb

@jdkfx jdkfx marked this pull request as ready for review December 18, 2024 15:30
@jdkfx jdkfx requested a review from a team as a code owner December 18, 2024 15:30
@jdkfx jdkfx requested review from Hiroshiba and removed request for a team December 18, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant