Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllDialogからHelpDialogを切り出す #2419

Merged
Merged
8 changes: 0 additions & 8 deletions src/components/Dialog/AllDialog.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
v-model="isAcceptRetrieveTelemetryDialogOpenComputed"
/>
<AcceptTermsDialog v-model="isAcceptTermsDialogOpenComputed" />
<HelpDialog v-model="isHelpDialogOpenComputed" />
<SettingDialog v-model="isSettingDialogOpenComputed" />
<HotkeySettingDialog v-model="isHotkeySettingDialogOpenComputed" />
<ToolBarCustomDialog v-model="isToolbarSettingDialogOpenComputed" />
Expand All @@ -28,7 +27,6 @@

<script setup lang="ts">
import { computed } from "vue";
import HelpDialog from "@/components/Dialog/HelpDialog/HelpDialog.vue";
import SettingDialog from "@/components/Dialog/SettingDialog/SettingDialog.vue";
import HotkeySettingDialog from "@/components/Dialog/HotkeySettingDialog.vue";
import ToolBarCustomDialog from "@/components/Dialog/ToolBarCustomDialog.vue";
Expand All @@ -49,12 +47,6 @@ const props = defineProps<{
}>();
const store = useStore();

// ライセンス表示
const isHelpDialogOpenComputed = computed({
get: () => store.state.isHelpDialogOpen,
set: (val) => store.actions.SET_DIALOG_OPEN({ isHelpDialogOpen: val }),
});

// 設定
const isSettingDialogOpenComputed = computed({
get: () => store.state.isSettingDialogOpen,
Expand Down
29 changes: 10 additions & 19 deletions src/components/Dialog/HelpDialog/HelpDialog.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<QDialog
v-model="modelValueComputed"
ref="dialogRef"
maximized
transitionShow="jump-up"
transitionHide="jump-down"
Expand Down Expand Up @@ -32,7 +32,7 @@
icon="close"
color="display"
aria-label="ヘルプを閉じる"
@click="modelValueComputed = false"
@click="onDialogOK"
/>
</QToolbar>
</QHeader>
Expand Down Expand Up @@ -74,6 +74,7 @@
<script setup lang="ts">
import { computed, ref } from "vue";
import type { Component } from "vue";
import { useDialogPluginComponent } from "quasar";
import MarkdownView from "./HelpMarkdownViewSection.vue";
import OssLicense from "./HelpOssLicenseSection.vue";
import UpdateInfo from "./HelpUpdateInfoSection.vue";
Expand All @@ -99,17 +100,7 @@ type PageSeparator = {
};
type PageData = PageItem | PageSeparator;

const props = defineProps<{
modelValue: boolean;
}>();
const emit = defineEmits<{
(e: "update:modelValue", val: boolean): void;
}>();

const modelValueComputed = computed({
get: () => props.modelValue,
set: (val) => emit("update:modelValue", val),
});
const { dialogRef, onDialogOK } = useDialogPluginComponent();

// エディタのアップデート確認
const store = useStore();
Expand All @@ -132,21 +123,21 @@ const newUpdateResult = useFetchNewUpdateInfos(
const licenses = ref<Record<string, string>[]>();
void store.actions.GET_OSS_LICENSES().then((obj) => (licenses.value = obj));

const policy = ref<string>();
const policy = ref<string>("");
void store.actions.GET_POLICY_TEXT().then((obj) => (policy.value = obj));

const howToUse = ref<string>();
const howToUse = ref<string>("");
void store.actions.GET_HOW_TO_USE_TEXT().then((obj) => (howToUse.value = obj));

const ossCommunityInfos = ref<string>();
const ossCommunityInfos = ref<string>("");
void store.actions
.GET_OSS_COMMUNITY_INFOS()
.then((obj) => (ossCommunityInfos.value = obj));

const qAndA = ref<string>();
const qAndA = ref<string>("");
void store.actions.GET_Q_AND_A_TEXT().then((obj) => (qAndA.value = obj));

const contact = ref<string>();
const contact = ref<string>("");
void store.actions.GET_CONTACT_TEXT().then((obj) => (contact.value = obj));

const pagedata = computed(() => {
Expand Down Expand Up @@ -202,7 +193,7 @@ const pagedata = computed(() => {
}
: {
isUpdateAvailable: false,
latestVersion: undefined,
latestVersion: "",
}),
},
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</template>

<script setup lang="ts">
import { onMounted, ref } from "vue";
import { computed } from "vue";
import BaseDocumentView from "@/components/Base/BaseDocumentView.vue";
import BaseScrollArea from "@/components/Base/BaseScrollArea.vue";
import { useMarkdownIt } from "@/plugins/markdownItPlugin";
Expand All @@ -21,12 +21,10 @@ const props = defineProps<{
markdown: string;
}>();

const documentHtml = ref("");

const md = useMarkdownIt();

onMounted(async () => {
documentHtml.value = md.render(props.markdown);
const documentHtml = computed(() => {
return md.render(props.markdown);
});
</script>

Expand Down
22 changes: 7 additions & 15 deletions src/components/Menu/MenuBar/MenuBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,15 @@

<script setup lang="ts">
import { ref, computed, watch } from "vue";
import { useQuasar } from "quasar";
import { useQuasar, Dialog } from "quasar";
import { MenuItemData, MenuItemRoot } from "../type";
import MenuButton from "../MenuButton.vue";
import TitleBarButtons from "./TitleBarButtons.vue";
import TitleBarEditorSwitcher from "./TitleBarEditorSwitcher.vue";
import { useStore } from "@/store";
import { HotkeyAction, useHotkeyManager } from "@/plugins/hotkeyPlugin";
import { useEngineIcons } from "@/composables/useEngineIcons";
import HelpDialog from "@/components/Dialog/HelpDialog/HelpDialog.vue";

const props = defineProps<{
/** 「ファイル」メニューのサブメニュー */
Expand Down Expand Up @@ -113,13 +114,11 @@ watch(titleText, (newTitle) => {
window.document.title = newTitle;
});

// FIXME: この関数は不要なはず
const closeAllDialog = () => {
void store.actions.SET_DIALOG_OPEN({
isSettingDialogOpen: false,
});
void store.actions.SET_DIALOG_OPEN({
isHelpDialogOpen: false,
});
Hiroshiba marked this conversation as resolved.
Show resolved Hide resolved
void store.actions.SET_DIALOG_OPEN({
isHotkeySettingDialogOpen: false,
});
Expand All @@ -134,12 +133,6 @@ const closeAllDialog = () => {
});
};

const openHelpDialog = () => {
void store.actions.SET_DIALOG_OPEN({
isHelpDialogOpen: true,
});
};

const toggleFullScreen = async () => {
window.backend.toggleFullScreen();
};
Expand Down Expand Up @@ -538,11 +531,10 @@ const menudata = computed<MenuItemData[]>(() => [
type: "button",
label: "ヘルプ",
onClick: () => {
if (store.state.isHelpDialogOpen) closeAllDialog();
else {
closeAllDialog();
openHelpDialog();
}
closeAllDialog();
Dialog.create({
component: HelpDialog,
});
Hiroshiba marked this conversation as resolved.
Show resolved Hide resolved
},
disableWhenUiLocked: false,
},
Expand Down
1 change: 0 additions & 1 deletion src/store/type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1968,7 +1968,6 @@ export type UiStoreState = {
} & DialogStates;

export type DialogStates = {
isHelpDialogOpen: boolean;
isSettingDialogOpen: boolean;
isCharacterOrderDialogOpen: boolean;
isDefaultStyleSelectDialogOpen: boolean;
Expand Down
1 change: 0 additions & 1 deletion src/store/ui.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ export const uiStoreState: UiStoreState = {
reloadingLock: false,
inheritAudioInfo: true,
activePointScrollMode: "OFF",
isHelpDialogOpen: false,
isSettingDialogOpen: false,
isHotkeySettingDialogOpen: false,
isToolbarSettingDialogOpen: false,
Expand Down
Loading