Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ソング: 正式なカラーとスタイルを定義する #2218

Merged
merged 82 commits into from
Sep 27, 2024
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
779f00c
シング側のカラーを定義する+それにあわせたスタイル調整
romot-co Aug 13, 2024
cdf244f
async/awaitのlintエラー修正
romot-co Aug 13, 2024
5d0a11e
調整
romot-co Aug 13, 2024
a1316d5
調整 [update snapshots]
romot-co Aug 13, 2024
50060af
調整 [update snapshots]
romot-co Aug 14, 2024
e39f017
(スナップショットを更新)
github-actions[bot] Aug 14, 2024
107e9bd
調整+テスト落ちるのを修正
romot-co Aug 14, 2024
ccba6e4
Merge branch 'feature/1810_sing_colors_and_styles' of https://github.…
romot-co Aug 14, 2024
d2060c6
Merge remote-tracking branch 'origin/main' into feature/1810_sing_col…
romot-co Aug 15, 2024
9628f16
(スナップショットを更新)
github-actions[bot] Aug 15, 2024
75140af
不要なasync/awaitを付与していたのを修正
romot-co Aug 16, 2024
20358ff
不要なasync/awaitを付与していたのを修正
romot-co Aug 16, 2024
9117056
指摘点調整
romot-co Aug 17, 2024
08732d9
指摘事項修正 [update snapshots]
romot-co Aug 17, 2024
8ba3ded
指摘事項修正
romot-co Aug 17, 2024
0af8e2f
指摘事項修正 [update snapshots]
romot-co Aug 17, 2024
3b35fb4
最低サイズやノートが連続している場合でも歌詞の可読性を上げる
romot-co Aug 17, 2024
3023a1f
lyricTextの位置調整
romot-co Aug 18, 2024
d4572f2
テスト修正
romot-co Aug 18, 2024
7e9466c
テストを修正
romot-co Aug 18, 2024
0aa3c43
Merge branch 'feature/1810_sing_colors_and_styles' of https://github.…
romot-co Aug 18, 2024
8b64123
ピッチカラーの修正
romot-co Aug 18, 2024
d62cbf6
指摘事項修正(SASSバージョンアップ以外)
romot-co Aug 18, 2024
7a072ab
SASSバージョンアップ+明度調整
romot-co Aug 18, 2024
5cc11dd
リサイズ中はカーソルを固定する
romot-co Aug 18, 2024
3fb4092
テーマ変更時にピッチラインカラーを変更する
romot-co Aug 18, 2024
7cf812a
ダークモード微調整
romot-co Aug 18, 2024
ac9244a
ピッチカラー調整
romot-co Aug 19, 2024
7915efa
仕掛かり調整
romot-co Aug 19, 2024
a13dfcd
仕掛かり調整
romot-co Aug 19, 2024
722f631
ピッチ表示の調整
romot-co Aug 21, 2024
8f6ffeb
ピッチ編集調整
romot-co Aug 21, 2024
effe904
ピッチ周辺の調整
romot-co Aug 22, 2024
671e51c
微調整
romot-co Aug 22, 2024
25d355e
調整
romot-co Aug 22, 2024
8d480a3
調整
romot-co Aug 22, 2024
ad54e0f
ピッチラインカラーを緑に
romot-co Aug 25, 2024
06eae90
調整
romot-co Aug 26, 2024
52cdcd5
調整
romot-co Aug 26, 2024
c421fbe
ピッチライン調整
romot-co Aug 26, 2024
1bc6ad8
SASS除算フォーマット修正+コメントなど
romot-co Aug 27, 2024
09e7cb0
フォントウェイトを400に
romot-co Aug 28, 2024
c287d89
font-weight: 500の使用をやめる
romot-co Aug 29, 2024
53cb32c
Update src/styles/v2/sing-colors.scss
romot-co Aug 29, 2024
f6f0232
コメント付与
romot-co Aug 30, 2024
79947b4
Update src/components/Sing/ScoreSequencer.vue
romot-co Sep 4, 2024
f010c49
Update src/components/Sing/SequencerNote.vue
romot-co Sep 4, 2024
3982f6b
修正仕掛かり
romot-co Sep 4, 2024
b63ffc0
Merge remote-tracking branch 'origin/main' into feature/1810_sing_col…
romot-co Sep 4, 2024
9acbb2f
ダーク調整
romot-co Sep 4, 2024
c1472ef
Merge remote-tracking branch 'refs/remotes/origin/feature/1810_sing_c…
romot-co Sep 4, 2024
d9b386d
指摘点修正
romot-co Sep 9, 2024
a8fa799
ピッチカラー調整
romot-co Sep 10, 2024
d6220a6
鍵盤の罫線
romot-co Sep 10, 2024
ddb6916
鍵盤右線および罫線色調整
romot-co Sep 11, 2024
8ec1170
明度調整
romot-co Sep 11, 2024
ab1a690
指摘点修正
romot-co Sep 12, 2024
9f57af1
ズームに応じたフォントサイズ係数の調整
romot-co Sep 12, 2024
6de0fbe
ラベルカラー
romot-co Sep 12, 2024
a4f25df
スナップ線調整
romot-co Sep 13, 2024
7c26dcf
右端や明度調整
romot-co Sep 13, 2024
3baf108
ダークモードのFラインを修正
romot-co Sep 13, 2024
3c2c476
右端ライン調整
romot-co Sep 14, 2024
7cf9614
指摘点修正
romot-co Sep 17, 2024
02b761c
リファクタリング仕掛かり
romot-co Sep 17, 2024
caeb71c
Noteの状態をリファクタリング
romot-co Sep 17, 2024
270b75f
Update src/components/Sing/ToolBar/ToolBar.vue
romot-co Sep 17, 2024
90bc76a
Update src/styles/v2/sing-colors.scss
romot-co Sep 17, 2024
ffc771c
Update src/styles/v2/sing-colors.scss
romot-co Sep 17, 2024
e2a1381
Update src/components/Sing/ToolBar/ToolBar.vue
romot-co Sep 17, 2024
3fd7c2b
EditTargetSwitcherのHandleKeyDownを削除
romot-co Sep 17, 2024
a8507c4
EventTargetSwitcherのHandleKeyDownを削除
romot-co Sep 17, 2024
66036a2
z-index問題があるためNoteの実装を戻す
romot-co Sep 17, 2024
8dcd099
状態を整理・プレビュー状態を一部composableに
romot-co Sep 18, 2024
d9f709c
コメント修正
romot-co Sep 18, 2024
7110576
ピッチ編集時の.note-edgeのhoverを抑制
romot-co Sep 18, 2024
8e04c7d
ピッチ削除のカーソルをdefaultに修正
romot-co Sep 19, 2024
ef38fa1
Update src/components/Sing/SequencerNote.vue
romot-co Sep 19, 2024
4f3b818
usePreviewModeを削除
romot-co Sep 20, 2024
46f6ab7
useCursorStateおよびカーソル状態の修正
romot-co Sep 20, 2024
1cff932
ノートのcursorを適切にセットする
romot-co Sep 20, 2024
0ae4294
指摘事項修正
romot-co Sep 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions public/themes/dark.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,6 @@
"warning": "#F27483",
"text-splitter-hover": "#394152",
"active-point-focus": "#292F38",
"active-point-hover": "#272A2F",
"sequencer-whitekey-cell": "#393939",
"sequencer-blackkey-cell": "#2D2D2D",
"sequencer-main-divider": "#121212",
"sequencer-sub-divider": "#2C2C2C",
"sequencer-white-key": "#EEEEEE",
"sequencer-black-key": "#555555"
"active-point-hover": "#272A2F"
}
}
8 changes: 1 addition & 7 deletions public/themes/default.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,6 @@
"warning": "#C10015",
"text-splitter-hover": "#CCDDFF",
"active-point-focus": "#E0EAFF",
"active-point-hover": "#EEF3FF",
"sequencer-whitekey-cell": "#F5F7F5",
"sequencer-blackkey-cell": "#EAECEA",
"sequencer-main-divider": "#B0B0B0",
"sequencer-sub-divider": "#CECECE",
"sequencer-white-key": "#FFFFFF",
"sequencer-black-key": "#333333"
"active-point-hover": "#EEF3FF"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ const reassignSubMenuOpen = debounce((idx: number) => {
subMenuOpenFlags.value = arr;
}, 100);

const changeStyleId = (speakerUuid: SpeakerId, styleId: StyleId) => {
const changeStyleId = async (speakerUuid: SpeakerId, styleId: StyleId) => {
const engineId = store.state.engineIds.find((_engineId) =>
(store.state.characterInfos[_engineId] ?? []).some(
(characterInfo) =>
Expand All @@ -152,7 +152,7 @@ const changeStyleId = (speakerUuid: SpeakerId, styleId: StyleId) => {
`No engineId for target character style (speakerUuid == ${speakerUuid}, styleId == ${styleId})`,
);

void store.dispatch("COMMAND_SET_SINGER", {
await store.dispatch("COMMAND_SET_SINGER", {
trackId: props.trackId,
singer: { engineId, styleId },
withRelated: true,
Expand Down
31 changes: 31 additions & 0 deletions src/components/Sing/CharacterMenuButton/MenuButton.vue
Hiroshiba marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(判断メモです)

この変更によって、トークとソングでキャラクターキャラクター選択ボタンの見た目の乖離が起こりますが、大きくずれすぎなければ問題ないと思っています!
やっぱりトークとソングで最適なUIの微妙なチューニングは変わってくると思うので。

(これ前もコメントしたかも)

Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,34 @@ const selectedSinger = computed(() => {
return store.getters.SELECTED_TRACK.singer;
});
</script>

<style scoped lang="scss">
@use "@/styles/variables" as vars;
@use "@/styles/colors" as colors;

sigprogramming marked this conversation as resolved.
Show resolved Hide resolved
.character-menu {
.q-menu {
:deep(.q-menu__container) {
border-radius: 1.25rem;
}
}
.q-item {
color: var(--scheme-color-on-surface);
}
.q-btn-group {
> .q-btn:first-child > :deep(.q-btn__content) {
justify-content: flex-start;
}
> div:last-child:hover {
background-color: rgba(var(--scheme-color-secondary-rgb), 0.1);
}
}
.engine-icon {
position: absolute;
width: 13px;
height: 13px;
bottom: -6px;
right: -6px;
}
}
</style>
70 changes: 47 additions & 23 deletions src/components/Sing/CharacterMenuButton/SelectedCharacter.vue
Original file line number Diff line number Diff line change
@@ -1,27 +1,23 @@
<template>
<div v-if="props.showSkeleton" class="selected-character">
<QSkeleton class="character-avatar" type="QAvatar" size="52px" />
<QSkeleton class="character-avatar" type="QAvatar" size="40px" />
<div class="character-info">
<QSkeleton
class="character-name skeleton"
type="rect"
width="65px"
height="15px"
width="64px"
height="16px"
/>
<QSkeleton
class="character-style"
type="rect"
width="110px"
height="12px"
height="8px"
/>
</div>
</div>
<div v-else class="selected-character">
<QAvatar
v-if="selectedStyleIconPath"
class="character-avatar"
size="3.5rem"
>
<QAvatar v-if="selectedStyleIconPath" class="character-avatar">
<img :src="selectedStyleIconPath" class="character-avatar-icon" />
</QAvatar>
<div class="character-info">
Expand Down Expand Up @@ -83,12 +79,32 @@ const selectedStyleIconPath = computed(() => {
@use "@/styles/colors" as colors;
sigprogramming marked this conversation as resolved.
Show resolved Hide resolved

.selected-character {
border: 1px solid var(--scheme-color-outline-variant);
border-radius: 4px 0 0 4px;
align-items: center;
display: flex;
padding: 0.25rem 0.5rem 0.25rem 0.25rem;
padding: 0 8px 0 4px;
position: relative;
height: 40px;
font-smooth: antialiased;

&:hover {
border-color: var(--scheme-color-outline);
background: rgba(var(--scheme-color-secondary-container-rgb), 0.1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oklch( / alpha値)としてるところもあったのでどちらかに統一しておくと良さそうかもです!
何か意図していたら別に両方でも。と思ったけどもしかしたらrgbが残ってるのはここだけかな?

}

&:focus {
border-color: var(--scheme-color-primary);
}

.character-avatar {
background: var(--scheme-color-background);
width: 36px;
height: 36px;
}

.character-avatar-icon {
border: 1px solid var(--scheme-color-outline-variant);
display: block;
height: 100%;
object-fit: cover;
Expand All @@ -99,33 +115,41 @@ const selectedStyleIconPath = computed(() => {
align-items: start;
display: flex;
flex-direction: column;
margin-left: 0.5rem;
margin-left: 8px;
text-align: left;
justify-content: center;
white-space: nowrap;
font-optical-sizing: auto;
}

.character-name {
font-size: 0.875rem;
font-weight: bold;
line-height: 1rem;
padding-top: 0.5rem;
color: var(--scheme-color-on-surface);
font-size: 14px;
font-weight: 500;
line-height: 24px;
padding-top: 12px;
margin-bottom: 0;
font-optical-sizing: auto;

&.skeleton {
margin-top: 0.4rem;
margin-bottom: 0.2rem;
margin-top: 0;
margin-bottom: 0;
}
}

.character-style {
color: rgba(colors.$display-rgb, 0.6);
font-size: 0.75rem;
font-weight: bold;
line-height: 1rem;
color: var(--scheme-color-on-surface-variant);
font-size: 9px;
transform: translateY(-5px);
font-weight: 400;
line-height: 16px;
margin-bottom: 8px;
}

.character-menu-dropdown-icon {
color: rgba(colors.$display-rgb, 0.8);
margin-left: 0.25rem;
display: none;
color: var(--scheme-color-on-surface-variant);
margin-left: 4px;
}
}
</style>
Loading