Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path for resource files #43

Merged
merged 3 commits into from
May 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions MANIFEST.in
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
include LICENSE.txt
include README.md
include requirements.txt
include bdi-kit/resource/*.json
include bdi-kit/resource/*.csv
include bdikit/resource/*.json
include bdikit/resource/*.csv
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ To install the latest development version:
pip install git+https://github.com/VIDA-NYU/bdi-kit@devel
```

Download the pre-trained model for mapping recommendations from [here](https://drive.google.com/file/d/1YdCTd-kUMjDJaltQwXN4X9ezTCsfjyft/view) (we show how to use it in our examples).


## Documentation
See our examples [here](https://github.com/VIDA-NYU/bdi-kit/tree/devel/examples).
Expand Down
2 changes: 1 addition & 1 deletion bdikit/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def load_dataset(self, dataset_path):
def reduce_scope(self):
self.scope_manager = ScopeReducingManager(self.dataset, self.global_table)
self.reduced_scope = self.scope_manager.reduce()
return plot_reduce_scope(self.reduced_scope, self.dataset)
plot_reduce_scope(self.reduced_scope, self.dataset)

def map_columns(self, algorithm='SimFloodAlgorithm'):
self.column_manager = ColumnMappingManager(self.dataset, self.global_table, algorithm)
Expand Down
3 changes: 1 addition & 2 deletions bdikit/visualization/mappings.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,12 @@

def plot_reduce_scope(reduced_scope, dataset):
scope_explorer = ScopeReducerExplorer(dataset, reduced_scope)
return scope_explorer.explore()
display(scope_explorer.explore())

def plot_column_mappings(column_mappings):
column_mappings_df = pd.DataFrame(column_mappings.items(), columns=['Original Column', 'Target Column'])
display(column_mappings_df)


def plot_value_mappings(value_mappings, include_unmatches=True):
sorted_results = sorted(value_mappings.items(), key=lambda x: x[1]['coverage'], reverse=True)

Expand Down
Loading