Amend text inputs for string params #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmfalke
requested changes
Jan 24, 2024
There was a problem hiding this comment.
See the requested change below. It will necessitate a change in QuestionDecoders.ts, and requires completion of VEuPathDB/WDK#78.
| onChange={onParamValueChange} | ||
| required={!parameter.allowEmptyValue} | ||
| size={40} |
There was a problem hiding this comment.
If parameter.isNumber is true, set this to 20.
There was a problem hiding this comment.
I realized that I never made it clear that StringParam can also be used for numbers, even though we do have a NumberParam. It's possible isNumber is not used anymore.
dmfalke
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #612