Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy range types #460

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Remove legacy range types #460

wants to merge 3 commits into from

Conversation

ryanrdoherty
Copy link
Member

This is to address some proposed backend changes described below. Decided NOT to implement those changes at this time (Aug 2023) because of the client impact and possible DB migration (gross). But wanted to document what would be needed. Note if we move forward the client dev should revert these and then use an IDE to redo them to make the change in all the dependent locations. This code as is will not compile.


// removed

  BinRange:
      binStart: string
      binEnd: string
      binLabel: string
  BinRangeWithValue: BinRange
      value: number
  RangeWithCountAndValue: BinRangeWithValue
      count: number

// added

  Range:
      min: string
      max: string
  LabeledRange: Range
      label: string
  LabeledRangeWithValue: LabeledRange
      value: number

// changed

// I believe this is service-side only
AllBinRanges: BinRange -> LabeledRange

ContinousOverlayConfig: overlayValues BinRange[] -> LabeledRange[]

StandaloneMapElementInfo: overlayValues RangeWithCountAndValue[] -> LabeledRangeWithValue[]

@ryanrdoherty ryanrdoherty requested a review from dmfalke August 30, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant