Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBrowse2 component integration #1263

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

bobular
Copy link
Member

@bobular bobular commented Nov 8, 2024

You will need this in your genomics-site/.env

JBROWSE2_ENDPOINT=/jbrowse2
JBROWSE2_URL=${BASE_PROXY_URL}/jbrowse2

Copy link
Member

@dmfalke dmfalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I made a comment :)

// Could use wdk usePromise? or react-query?
useEffect(() => {
// Fetch the config JSON
fetch('/jbrowse2/config.json')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, this would be a configuration value that gets set in configer. Something like jbrowse2_root_url = /jbrowse2. Then, you can update __SITE_CONFIG__ in EbrcWebsiteCommon/Model/lib/conifer/roles/conifer/templates/EbrcWebsiteCommon/appBase.html.j2 to include that value. Then, update packages/libs/web-common/src/config.ts to export that value. Finally, you can import that here via import { jbrowse2RootUrl } from 'web-common/lib/config';.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants