Exchange defaultProps for default parameters in function components #1226
Conversation
|
Started looking into removing |
| shouldCloseOnSelection, | ||
| wrapPopover, | ||
| currentList, | ||
| selectedList = [], |
There was a problem hiding this comment.
I don't think we need this. Isn't selectedList an option prop for CheckboxTree?
There was a problem hiding this comment.
It is but we use selectedList below to auto close the popover.
setKey(selectedList.join(', '));
packages/libs/coreui/src/components/inputs/checkboxes/CheckboxTree/CheckboxTree.tsx
Outdated
Show resolved
Hide resolved
packages/libs/coreui/src/components/inputs/checkboxes/CheckboxTree/CheckboxTree.tsx
Outdated
Show resolved
Hide resolved
packages/libs/coreui/src/components/inputs/checkboxes/CheckboxTree/CheckboxTree.tsx
Outdated
Show resolved
Hide resolved
packages/libs/coreui/src/components/inputs/checkboxes/CheckboxTree/CheckboxTree.tsx
Outdated
Show resolved
Hide resolved
packages/libs/coreui/src/components/inputs/checkboxes/CheckboxTree/CheckboxTree.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
It occurred to me that you could do something like this in the component:
function CheckboxTree<T>(partialProps: Props<T>) {
const props = { ...defaultProps, ...partialProps };
// ...
}If a prop is defined in partialProps, it's value will be used; otherwise, the value in defaultProps will be used.
There was a problem hiding this comment.
This would be so much nicer. I tried this for a bit but could not shake a missing in types validation default props error. Even after ensuring props was of the correct type.
Happy to try something else if you have an idea of how to get around this!
Co-authored-by: Dave Falke <[email protected]>
|
@dmfalke I finally got around to responding to comments! I also couldn't find a way around a type issue. But otherwise was mostly able to apply your suggestions! |
|
Testing now, and will re-request a review when tests are complete |
|
Looking good now. Ready for another look when you have a min, @dmfalke ! |
Partially resolves #1218
defaultPropsis being deprecated for function components. This PR removes the olddefaultPropsfrom all function components.Below is the list that Bob provided (for completeness). I either completed the update or found it was not a case that needed changing:
I also found
deafultPropsinCompound.jsx,Gbrowse.jsx, andOverviewThumbnail.jsxbut they were all being used with class components.Notes
SelectTree, I removed the default props entirely if they both were the same as the component they were being passed to and caused no errors when removing.CheckboxTree.tsxrelied on default values being set, so i defined them in the file and then reused these values across the different functions.Sequencecomponent on gene record pages. Where does it get loaded? Otherwise I checked all the other updated components on the genomics or mbio site.