replace mutating state with better check of filters

VEuPathDB · Dec 19, 2024 · 423446b · 423446b
1 parent 5982792
commit 423446b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/packages/libs/eda/src/lib/core/components/visualizations/VisualizationsContainer.tsx b/packages/libs/eda/src/lib/core/components/visualizations/VisualizationsContainer.tsx
@@ -833,7 +833,8 @@ function ConfiguredVisualizationGrayOut({
     }
 
     // using lodash isEqual to compare two objects
-    if (!isEqual(filters, currentPlotFilters)) {
+    // Sometimes filters or currentPlotFilters are undefined. In that case, assume there are no filters applied.
+    if (!isEqual(filters ?? [], currentPlotFilters ?? [])) {
       return (
         <>
           Open to sync with

diff --git a/...s/eda/src/lib/core/components/visualizations/implementations/VolcanoPlotVisualization.tsx b/...s/eda/src/lib/core/components/visualizations/implementations/VolcanoPlotVisualization.tsx
@@ -136,9 +136,6 @@ function VolcanoPlotViz(props: VisualizationProps<Options>) {
     plotContainerStyleOverrides,
   } = props;
 
-  // If no filters applied, the currentPlotFilters will be undefined. It should be an empty array.
-  visualization.descriptor.currentPlotFilters =
-    visualization.descriptor.currentPlotFilters ?? [];
   const studyMetadata = useStudyMetadata();
   const { id: studyId } = studyMetadata;
   const entities = useStudyEntities(filters);