Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layouts #245

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Layouts #245

merged 4 commits into from
Feb 22, 2024

Conversation

d-callan
Copy link
Contributor

adding support for some layouts via igraph

@d-callan d-callan requested a review from asizemore February 16, 2024 16:10
Copy link
Member

@asizemore asizemore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember - Node already has x and y slots, right?

R/class-Network.R Show resolved Hide resolved
R/class-Network.R Show resolved Hide resolved
#' @param linkColorScheme string defining the type of coloring scheme the links follow.
#' Options are 'none' (default) and 'posneg'.
#' @param layout string defining the layout of the network. Options are 'force', 'circle',
#' and 'nicely' which are implemented in igraph. Default is 'nicely'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion - anything other than "nicely" for the default. "Nicely" isn't descriptive at all haha. I don't know what "nicely" means other than i expect it looks nice :) I think it'd be more helpful to see something plain but readable (such as "circle") and then choose a layout from more complicated options.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice is a nice option though. it goes through different algorithms i dont remember based on some network metrics i dont remember. and as the default, people dont have to ask for nicely, or ever see thats what its called. they just get it by default, and can ask for specific things by name. i cant imagine ever asking for a thing called nicely without knowing what it was..

R/constructors-Node.R Show resolved Hide resolved
R/methods-Nodes.R Show resolved Hide resolved
Base automatically changed from degree-list to main February 22, 2024 16:44
@d-callan
Copy link
Contributor Author

as promised #248

@d-callan d-callan merged commit 5e8c23e into main Feb 22, 2024
5 checks passed
@d-callan d-callan deleted the layouts branch February 22, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants