Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network tests #243

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Network tests #243

merged 4 commits into from
Feb 15, 2024

Conversation

d-callan
Copy link
Contributor

resolves #241

@d-callan d-callan requested a review from asizemore February 15, 2024 20:17
@d-callan
Copy link
Contributor Author

i made a first pass.. what else do we think needs to be here?

asizemore
asizemore approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@asizemore asizemore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing jumped out at me as missing, so lgtm!

@d-callan d-callan merged commit ca188e4 into main Feb 15, 2024
5 checks passed
@d-callan d-callan deleted the network-tests branch February 15, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asizemore asizemore asizemore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backend: improve test coverage of network classes in plot.data
2 participants
@d-callan @asizemore