-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network methods #235
Add network methods #235
Conversation
what all are we trying to accomplish w this pr? Ill say this.. it seems some things that still need doing, here or somewhere else, are:
does that list make sense? is that what this pr is for? |
I think 1 and 2 fits into this PR. 3 is a can of worms that i'm not sure i'm ready to open yet. 4 also yes - this PR was originally about creating methods that help validate a network and get it into/out of good formats. So in addition to what you have, i'd say things like
That's a long list so breaking it up into a few PRs is also cool. |
do we want to remove duplicate links and nodes? or just validate for them? the nodes at least it seems we just shouldnt allow that case, and then wed never need to remove them. for the links, i think id like to hear more about when wed intentionally include dups |
yeah validating makes sense for nodes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My most pressing questions are around the api - how much do we want to change, and how much can we reasonably change before the release?
Additionally, I think we need to give the linkColorSchemes a bit more thought on how we protect someone from making something nonsensical with link colors that are any float but the color scheme says "posneg" for example.
Finally, we added a bunch of methods but i think the coverage on testing is pretty low. Given how much testing we'd really want to add it's probably better if we make a separate PR to increase coverage.
If we do decide to push for the api change before 67, i'm okay with making new issues for the other changes and starting those after the api change is done
ill make a separate issue for test coverage, and we can make a list of things wed like to test there and decide whats a good time to do that. everything else i think i addressed today. im also in process of updating the api here to match the data service, and write bipartitenetwork explicitly if we know we have two partitions for the kpartite network. thatll be in here as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't approve a PR i co-authored but if i could i would! 🎉
Resolves #232
Added methods for networks and versions for bipartite networks where appropriate. Required for getting data into a network.