Bipartite network api update #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asizemore
approved these changes
Jan 30, 2024
| KPartiteNetwork: | ||
| additionalProperties: false | ||
| properties: | ||
| data: KPartiteNetworkData |
There was a problem hiding this comment.
Remind me what do we have planned for the partitions metadata?
| @@ -120,12 +120,20 @@ protected void writeResults(OutputStream out, Map<String, InputStream> dataStrea | |||
| BipartiteNetworkData bipartiteNetworkData = new BipartiteNetworkDataImpl(); | |||
| bipartiteNetworkData.setLinks(links); | |||
| bipartiteNetworkData.setNodes(nodes); | |||
| bipartiteNetworkData.setColumn1NodeIDs(uniqueColumn1IDs); | |||
| bipartiteNetworkData.setColumn2NodeIDs(uniqueColumn2IDs); | |||
| NodeIdList col1NodeIdList = new NodeIdListImpl(); | |||
There was a problem hiding this comment.
I think it's worth removing references to columns everywhere. There's no reason we need to even show the bp net in two columns (could be two rows, two blobs of nodes, or even nodes placed based on some layout algorithm but with two different colors), i just didn't have good words for it back in the day (4 months ago).
All that to say, i'd recommend "col1NodIdList" -> "partition1NodeIdList"
| bipartiteNetworkConfig.setColumn2Metadata(stats.getData2Metadata()); | ||
| List<String> partitionsMetadata = new ArrayList<String>(); | ||
| partitionsMetadata.add(stats.getData1Metadata()); | ||
| partitionsMetadata.add(stats.getData2Metadata()); |
There was a problem hiding this comment.
ahhh i remmber. that's what the metadata is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed here