fix another case of poor use of isValidEdgeList

VEuPathDB · Jan 30, 2024 · ae844fb · ae844fb
1 parent f296876
commit ae844fb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/R/constructors-Node.R b/R/constructors-Node.R
@@ -71,8 +71,8 @@ setMethod("NodeIdList", "character", function(object, uniquifyIds = c(TRUE, FALS
 
 #' @export 
 setMethod("NodeIdList", "data.frame", function(object, uniquifyIds = c(TRUE, FALSE)) {  
-  if (!isValidEdgeList(object)) {
-    stop(paste(errors, collapse = '\n'))
+  if (!inherits(isValidEdgeList(object), "logical")) {
+    stop(paste("Invalid edgeList:", isValidEdgeList(object), collapse = '\n'))
   }
 
   return(NodeIdList(c(object$source, object$target), uniquifyIds = uniquifyIds))

diff --git a/tests/testthat/test-nodes.R b/tests/testthat/test-nodes.R
@@ -84,7 +84,6 @@ test_that("NodeList methods work", {
 test_that("We cannot make nonsensical nodes", {
 
   expect_error(Node(id = FALSE))
-  #expect_error(Node(id = 10)) # why is this nonsensical?
   expect_error(Node(id = 'A', color = FALSE))
   expect_error(Node(id = 'A', weight = '10'))
 })