migrate analyses vdi ids #88
Conversation
| readVdiMappingFile(tinyDbFile); | ||
|
|
||
| // Default to dryrun to avoid incidental migrations when testing. | ||
| _writeToDb = Boolean.parseBoolean(args.getOrDefault("-write", "false")); |
There was a problem hiding this comment.
Should this have the double dash to be like the other args?
| .map(match -> match.group(1)) | ||
| .collect(Collectors.toSet()); | ||
|
|
||
| final String entityId = ENTITY_ID_PATTERN.matcher(descriptor).results() |
There was a problem hiding this comment.
Are we sure there's only one here? We could easily have a config with >1 variable spec, each of which might contain a different entity ID, especially across different visualizations.
There was a problem hiding this comment.
There's only one entity allowed in ISA simple studies
|
|
||
| return new TableRowInterfaces.RowResult<>(nextRow) | ||
| // Create a copy with just the dataset ID updated to VDI counterpart. | ||
| AnalysisRow out = new AnalysisRow(nextRow.getAnalysisId(), vdiDatasetId, new JSONObject(descriptor), |
There was a problem hiding this comment.
Could just use setters to assign dataset ID and descriptor here, but probably not much more expensive given the work above.
There was a problem hiding this comment.
Updated to use setters instead.
| AnalysisRow out = new AnalysisRow(nextRow.getAnalysisId(), vdiDatasetId, new JSONObject(descriptor), | ||
| nextRow.getNumFilters(), nextRow.getNumComputations(), nextRow.getNumVisualizations()); | ||
|
|
||
| LOG.info("Analysis descriptor after migration: " + out); |
There was a problem hiding this comment.
You're dumping the AnalysisRow here; might have a decent toString() but isn't necessarily good for comparing to the "before" log line above.
There was a problem hiding this comment.
Oops, meant to log just the descriptor.
Overview
Testing