Skip to content

Commit

Permalink
Don't propagate build errors during strategy build/run
Browse files Browse the repository at this point in the history
  • Loading branch information
ryanrdoherty committed Mar 29, 2024
1 parent fed8330 commit 6ff5fc2
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -417,21 +417,21 @@ Map<Long, Strategy> getAllStrategies(
UnbuildableStrategyList<WdkModelException> stratsWithBuildErrors) throws WdkModelException {
return getStrategies(
prepareSql(FIND_STRATEGIES_SQL.replace(SEARCH_CONDITIONS_MACRO, "")),
malformedStrategies, stratsWithBuildErrors);
false, malformedStrategies, stratsWithBuildErrors);
}

Map<Long, Strategy> getStrategies(long userId,
UnbuildableStrategyList<InvalidStrategyStructureException> malformedStrategies,
UnbuildableStrategyList<WdkModelException> stratsWithBuildErrors) throws WdkModelException {
return getStrategies(
prepareSql(FIND_STRATEGIES_SQL.replace(SEARCH_CONDITIONS_MACRO, "and sr." + COLUMN_USER_ID + " = " + userId)),
malformedStrategies, stratsWithBuildErrors);
false, malformedStrategies, stratsWithBuildErrors);
}

private Map<Long, Strategy> getStrategies(String searchSql,
private Map<Long, Strategy> getStrategies(String searchSql, boolean propagateBuildErrors,
UnbuildableStrategyList<InvalidStrategyStructureException> malformedStrategies,
UnbuildableStrategyList<WdkModelException> stratsWithBuildErrors) throws WdkModelException {
SearchResult result = doSearch(searchSql);
SearchResult result = doSearch(searchSql, propagateBuildErrors);
malformedStrategies.addAll(result.getMalformedStrategies());
stratsWithBuildErrors.addAll(result.getStratsWithBuildErrors());
return toStrategyMap(descModTimeSort(result.getStrategies()));
Expand Down

0 comments on commit 6ff5fc2

Please sign in to comment.