Don't replace empty description with display name; allows client to h…

…ide '?' icon
VEuPathDB · Oct 17, 2023 · 299202b · 299202b
1 parent c1275d3
commit 299202b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Model/src/main/java/org/gusdb/wdk/model/report/DynamicAttributeReporterReference.java b/Model/src/main/java/org/gusdb/wdk/model/report/DynamicAttributeReporterReference.java
@@ -98,9 +98,9 @@ public void setPluginProperties(String pluginProperties) throws WdkModelExceptio
   public boolean hasAllDynamicFields() {
     return (
         getName() != null &&
-            getDisplayName() != null &&
-            getDescription() != null &&
-            getImplementation() != null
+        getDisplayName() != null &&
+        //getDescription() != null && // description is allowed to be null
+        getImplementation() != null
     );
   }
 
@@ -109,7 +109,7 @@ public String getDynamicFieldsAsString() {
     String propsPrint = properties == null ? null : prettyPrint(properties, FormatUtil.Style.MULTI_LINE);
     return new StringBuilder("{").append(NL)
         .append("name:           ").append(getName()).append(NL)
-        .append("displayName:        ").append(getDisplayName()).append(NL)
+        .append("displayName:    ").append(getDisplayName()).append(NL)
         .append("description:    ").append(getDescription()).append(NL)
         .append("implementation: ").append(getImplementation()).append(NL)
         .append("properties:     ").append(propsPrint).append(NL)

diff --git a/Model/src/main/java/org/gusdb/wdk/model/report/ReporterRef.java b/Model/src/main/java/org/gusdb/wdk/model/report/ReporterRef.java
@@ -158,7 +158,7 @@ public void setDescription(WdkModelText description) {
   }
 
   public String getDescription() {
-    return (_description == null ? _displayName : _description);
+    return _description;
   }
 
   @Override