Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installable, dual py2+py3 compatibility, that fixes/tolerates some non-standard nodes #7

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

notlaast
Copy link

@notlaast notlaast commented Apr 3, 2019

I've started over with my pull request, to implement my changes on top of a rebased fork. I've implemented the following general changes

  • the code is totally compatible with both py2 and py3
  • the package can be installed via setuptools (that is, this works: "pip install ." and then "python -m vamdclib")
  • the local registry has been fixed so that the CDMS and JPL nodes point to the correct URLs
  • the registry works with some unidentified node that doesn't correctly provide a "referenceUrl"
  • requests to HTTPS connections have been found to fail under some specific combinations of py2.7 + urllib2 or openssl libraries because of broken/unacceptable request contexts, and I've added an optional argument when initializing a new request so that this verification can be skipped

@notlaast
Copy link
Author

notlaast commented Apr 3, 2019

By the way, my fork is based on several individual branches that focused on specific features.. please look more closely at my fork if you are interested in the details..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant