Fix memory leaks #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UweTrottmann
force-pushed
the
fix-memory-leaks
branch
2 times, most recently
from
a875783 to
ff4fe8a
Compare
UweTrottmann
force-pushed
the
fix-java-11-ipv6-format
branch
from
4713832 to
973d803
Compare
UweTrottmann
force-pushed
the
fix-memory-leaks
branch
from
ce93c37 to
907cf7e
Compare
UweTrottmann
force-pushed
the
fix-java-11-ipv6-format
branch
from
973d803 to
8646c41
Compare
Check requests are already sent when doing a request. Even if it would work on App Engine (no background threads allowed), there is no point in sending check requests again at some later point. Check requests are still cached (and expired).
UweTrottmann
force-pushed
the
fix-memory-leaks
branch
from
907cf7e to
fee6364
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check call of
Clientappears to be leaking memory.Turns out the
outQueue ofCheckRequestAggregatoris filled with expired cache entries. But as it is never flushed (which would be pointless anyhow as check requests are already sent before a request) as the scheduler background thread does not work on App Engine Standard this will leak aCheckResponsefor each user making a request.This removes the
outqueue completely fromCheckRequestAggregatorwhich never really aggregated anything, but only cached check request responses. Now it will only cache check request responses.