update output types of publishing assets, add cloud sensors #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jonathan Yong <[email protected]>
In particular: - TopLevelMetadata assets will return the actual classes instead of dataframes as this avoids unnecessary conversions between classes/dataframes (a common operation is extracting a field, e.g. an ID, in a downstream asset and while that can be done with df["field_name"].iloc[0] it's clenaer to just use class.field_name) - Geometry assets will return a list of (GeometryMetadata, gdf, names_df) because they cannot be separately partitioned The new IO managers have been disabled in this commit because I have introduced dependencies between some of the outputs. For example, the SourceDataRelease requires the ID of the GeometryMetadata which is constructed at runtime by the geometry asset. Since our IO managers only allow for output and not input, it is impossible to produce any assets that depend on those using the new IO managers. The way around this is to use the default IO managers for these assets themselves, and then create NEW assets which depend on these assets and exist solely to handle the output to local / Azure. Indeed, these 'new' assets can just be cloud sensors (which leads us VERY nicely into that bit of work which we were always going to do!) NOTE: This commit will break the Azure IO managers. They will be fixed soon.
…ent) I'm very much unsure what happens if two IO managers attempt to use the lease at the same time. To get the geometry sensor to work, I had to lengthen the sensor interval to 60 seconds and also disable the metadata sensor.
sgreenbury
reviewed
May 17, 2024
sgreenbury
reviewed
May 17, 2024
Co-authored-by: Jonathan Yong <[email protected]>
Co-authored-by: Jonathan Yong <[email protected]>
|
Noting on areas to be covered in other issues:
|
This was referenced May 17, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Still to do: