Search improvements #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgreenbury
force-pushed
the
81-search-improvements
branch
from
429011f to
116f277
Compare
Adds SearchConfig with `MatchType` (Exact, Regex, Contains, Startswith), and `CaseSensitivity` (Insensitive or Sensitive), adds a test, and incorporates into CLI with defaults for: - `SearchText` when across all search contexts (regex) - `MetricsId` (startswith, case insensitive)
sgreenbury
force-pushed
the
81-search-improvements
branch
from
116f277 to
1978d57
Compare
7 tasks
Merged
sgreenbury
force-pushed
the
81-search-improvements
branch
from
97140b0 to
0998aa8
Compare
|
Possible next steps/improvements for the next issues with user feedback:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81 and #82.
This PR includes:
SearchConfigas a field on different search param fields (MetricId,GeometryLevel, etc) that enable search type (regex, exact, contains, startswith) and case sensitivity (sensitive or insensitive) of the search for that search param field to be set--summary) and displaying column data (--column COLUMN_NAME,--unique COLUMN_NAME) from search results. These have been added as part of themetricssubcommand. It might be an improvement to create a separate subcommand for these instead to keep functionality more distinct.Remaining tasks:
display.rsto reduce repetition across different display functionsReview and consider refactoring/reducing the number of CLI options forRefactored flags into arg groups. It may be better to introduce a summary subcommand distinct to metrics.metricssubcommand