Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Homepage and Repository fields to manifests #211

Merged
merged 8 commits into from
Nov 17, 2024
Merged

Conversation

Dekkonot
Copy link
Member

Supersedes #180. Making a new PR because it's hard to repair that one after the work done on the site recently.

Closes #183.

@Dekkonot Dekkonot added rust Pull requests that update Rust code javascript Pull requests that update Javascript code labels Nov 16, 2024
Copy link
Member

@magnalite magnalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tiny nitpick - The repo text can run off the edge of the webpage. (I don't think it is worth caring about right now unless the fix is trivial. Just eliding the link if it is too long is probably fine.)
image
image

@Dekkonot
Copy link
Member Author

So, looking into fixing this: the link gets truncated on desktop too, since it's too long for the column:

image

Even trimming off the scheme of the URL like crates.io doesn't work, as our text is too large. If we drop it down a few points though, it's perfectly fine with the scheme cut off:
image

This does add a bit more work but it's probably worth it to ensure it looks okay?

Copy link

cloudflare-workers-and-pages bot commented Nov 17, 2024

Deploying wally-registry-frontend with  Cloudflare Pages  Cloudflare Pages

Latest commit: 11e3a9a
Status: ✅  Deploy successful!
Preview URL: https://60ab0acb.wally-registry-frontend.pages.dev
Branch Preview URL: https://test.wally-registry-frontend.pages.dev

View logs

@Dekkonot Dekkonot merged commit 4fa2344 into main Nov 17, 2024
3 checks passed
@Dekkonot Dekkonot deleted the homepage-repository branch November 17, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to package repo on wally website
3 participants