-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wally-registry-frontend Framework Migration #197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dekkonot
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, though I can't deploy them to test. Going to save this until later because I don't feel super comfortable merging this until we can get it on the test site, haha.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
UpliftMacaw
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #191, our previous bootstrapped architecture with Parcel for wally.run has completely stalled and failed during deployment. Further investigations into trying to upgrade our codebase to work with Parcel V2--as well as additional complications with a no-config bundler in Docker environments--prompted a new direction. This PR includes a total pivot to move all of our logic from a custom-built solution to a modern Next.js project. On top of being easier to maintain, this has the added benefits of making it more clear for newcomers to contribute changes with a familiar and larger presence in the modern web ecosystem.
Otherwise, all changes should be near 1-to-1 functionality duplicates with the current wally.run. I did add in fixes from the #191 PR for visual bugs and accessibility features, as well as a few more I noticed.
If this PR looks good, we can move forward with a new deployment strategy as well!