Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Amplitude (browser) + add Amplitude to the server side (API) #374

Merged
merged 17 commits into from
Jun 23, 2021
Merged

Refactor Amplitude (browser) + add Amplitude to the server side (API) #374

merged 17 commits into from
Jun 23, 2021

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented Jun 22, 2021 •
edited
Loading

Existing usage of Amplitude has been refactored

  • Avoid use of anonymous constants
  • Avoid mix of Sentry/Amplitude config
  • Clarify use of action (best practices + doc)

Added Amplitude to the server side:

  • All existing API endpoint send a api-invoked event now
  • Split browser usage and server usage (they're not compatible)
  • Test and figure out whether to await for logEvent on the server/api (TLDR; Yes, you should)

New issues:

@github-actions github-actions bot temporarily deployed to storybook June 22, 2021 09:49 Inactive
@github-actions github-actions bot temporarily deployed to customer1-staging June 22, 2021 09:49 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 2442d2f successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-4cw0jgzm4-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-refactor-amplitude.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 2442d2f successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-kbnskdwwl-unly-oss.vercel.app
Deployment aliases (1): nrn-v2-mst-aptd-at-lcz-sty-storybook.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 2442d2f previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-4cw0jgzm4-unly-oss.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 2442d2f previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-kbnskdwwl-unly-oss.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 8150a13 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-em2g7ecix-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-refactor-amplitude.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 8150a13 successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-bwscekk16-unly-oss.vercel.app
Deployment aliases (1): nrn-v2-mst-aptd-at-lcz-sty-storybook.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging June 22, 2021 09:58 Inactive
@github-actions
Copy link

✅  E2E tests SUCCESS for commit 8150a13 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-em2g7ecix-unly-oss.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 8150a13 previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-bwscekk16-unly-oss.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 65cf348 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-g08z6f5d9-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-refactor-amplitude.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 65cf348 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-g08z6f5d9-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to storybook June 22, 2021 11:11 Inactive
@github-actions github-actions bot temporarily deployed to customer1-staging June 22, 2021 11:11 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit d448b6d successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-a9fvj2e4m-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-refactor-amplitude.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit d448b6d successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-4b44brirz-unly-oss.vercel.app
Deployment aliases (1): nrn-v2-mst-aptd-at-lcz-sty-storybook.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit d448b6d previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-4b44brirz-unly-oss.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit d448b6d previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-a9fvj2e4m-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging June 22, 2021 13:08 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit cf25ae4 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-53oeha7nd-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-refactor-amplitude.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit cf25ae4 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-53oeha7nd-unly-oss.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 815ff95 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-azk1qxgsp-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-refactor-amplitude.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 815ff95 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-azk1qxgsp-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging June 22, 2021 19:26 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit d203562 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-9eb4u2mus-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-refactor-amplitude.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit d203562 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-9eb4u2mus-unly-oss.vercel.app

@Vadorequest Vadorequest changed the title Refactor Amplitude Refactor Amplitude (browser) + add Amplitude to the server side (API) Jun 23, 2021
@github-actions github-actions bot temporarily deployed to customer1-staging June 23, 2021 12:09 Inactive
@github-actions github-actions bot temporarily deployed to customer1-staging June 23, 2021 12:13 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 2334506 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-9o8g4bll0-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-refactor-amplitude.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit d36c7e4 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-7t1vm32e7-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-refactor-amplitude.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 2334506 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-9o8g4bll0-unly-oss.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit d36c7e4 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-7t1vm32e7-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging June 23, 2021 13:10 Inactive
@Vadorequest Vadorequest marked this pull request as ready for review June 23, 2021 13:15
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 3d15fcc successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-ky4e18wkb-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-refactor-amplitude.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 3d15fcc previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-ky4e18wkb-unly-oss.vercel.app

@Vadorequest
Revert "Don't await, doesn't seem necessary on Vercel (events are ing…
90e4aa1 
…ested correctly as expected)"

This reverts commit 5c7f1f3
@github-actions github-actions bot temporarily deployed to customer1-staging June 23, 2021 14:02 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 90e4aa1 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-iid30f3ar-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-refactor-amplitude.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 90e4aa1 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-iid30f3ar-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging June 23, 2021 14:18 Inactive
@Vadorequest Vadorequest merged commit b2aa41d into v2-mst-aptd-at-lcz-sty Jun 23, 2021
@Vadorequest Vadorequest deleted the refactor-amplitude branch June 23, 2021 14:19
Vadorequest added a commit that referenced this pull request Jun 23, 2021
@Vadorequest
Refactor Amplitude (browser) + add Amplitude to the server side (API)…
82aad2f 
… (Cherry-pick #374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vadorequest