chore: milestone strategy tabs #8851
Open
+192
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
nunogois
reviewed
Nov 25, 2024
frontend/src/component/releases/ReleasePlanTemplate/MilestoneStrategyTitle.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Nov 25, 2024
| constraints: [], | ||
| title: '', | ||
| id: 'temp', | ||
| }); |
There was a problem hiding this comment.
Why do we need this? If the only purpose is to fill the default values of a new strategy I think there are better options, like making this a responsibility of ReleasePlanTemplateAddStrategyForm instead.
There was a problem hiding this comment.
I'll take another look at it, was a little annoying with all the strategy?.prop everywhere. The other solution would be to add a route for it like we do in features, but I didn't want to mess around with route if I have a built template object in create waiting to be submitted
There was a problem hiding this comment.
That's okay, we can proceed with this for now and clean up later
nunogois
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tabs and submit/save button to add strategy form