#58, allDimensions should be visible all the time regardless of the a…

…ctual dimension selections
UniversityOfHelsinkiCS · Mar 8, 2023 · 787b869 · 787b869
1 parent 9af24eb
commit 787b869
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/client/components/ResultPage/Results.tsx b/src/client/components/ResultPage/Results.tsx
@@ -54,20 +54,16 @@ const Results = ({ formResultData }: { formResultData: FormValues }) => {
   )
   const courseCompletionMethodId = courseCompletionMethodQuestion.id
 
-  const isAllDimensionsSelected: boolean = Object.values(
-    formResultData[dimensionQuestionId]
-  ).every((dimension) => dimension)
-
   const multipleChoiceObjectToArray = (aChoiceId: number): string[] =>
     Object.keys(formResultData[aChoiceId]).filter(
       (index) => formResultData[aChoiceId][index]
     )
 
   const modifiedResultObject = {
     ...formResultData,
-    [dimensionQuestionId]: isAllDimensionsSelected
-      ? ['allDimensions']
-      : multipleChoiceObjectToArray(dimensionQuestionId),
+    [dimensionQuestionId]: ['allDimensions'].concat(
+      multipleChoiceObjectToArray(dimensionQuestionId)
+    ),
     [courseCompletionMethodId]: multipleChoiceObjectToArray(
       courseCompletionMethodId
     ),