Only show Ready status option to admins, when disabling status field …

…consider only initialThesis state
UniversityOfHelsinkiCS · Dec 12, 2024 · 64cc882 · 64cc882
1 parent 8ef168e
commit 64cc882
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/client/components/ThesisPage/ThesisEditForm.tsx b/src/client/components/ThesisPage/ThesisEditForm.tsx
@@ -405,7 +405,7 @@ const ThesisEditForm: FC<{
                 data-testid="status-select-input"
                 required
                 disabled={
-                  editedThesis.status === 'PLANNING' &&
+                  initialThesis.status === 'PLANNING' &&
                   !user.isAdmin &&
                   !user.approvableProgramIds?.includes(editedThesis.programId)
                 }
@@ -429,9 +429,11 @@ const ThesisEditForm: FC<{
                 <MenuItem value="IN_PROGRESS">
                   {t(StatusLocale.IN_PROGRESS)}
                 </MenuItem>
-                <MenuItem value="COMPLETED">
-                  {t(StatusLocale.COMPLETED)}
-                </MenuItem>
+                {user.isAdmin && (
+                  <MenuItem value="COMPLETED">
+                    {t(StatusLocale.COMPLETED)}
+                  </MenuItem>
+                )}
                 <MenuItem value="CANCELLED">
                   {t(StatusLocale.CANCELLED)}
                 </MenuItem>