-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMCL-1591: Add SplineDollyLookAtTargets component #998
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #998 +/- ##
==========================================
- Coverage 26.83% 26.66% -0.17%
==========================================
Files 249 251 +2
Lines 28000 28207 +207
==========================================
+ Hits 7513 7522 +9
- Misses 20487 20685 +198 ☔ View full report in Codecov by Sentry. |
Replaced by #999 |
Purpose of this PR
CMCL-1591
New feature! Specifies LookAt data points for positions along a spline, so that a dolly camera looks at those places when it reaches specific positions on the spline.
New scene view tool to edit those points (works like SplineRoll tool):
Testing status
Documentation status
Technical risk
low
Comments to reviewers
The tool icon is a placeholder, @JulienDidierjean is taking care of providing new icons.
Possible improvements (to think about):
Add option to specify a Transform to look at instead of a hardcoded pointdone!Prettier inspector (Data Points list is ugly - but this is provided by the spline team)done!Direct access to tool via button on inspectordone!Known Issues
@sebastienduverne Please review the user manual changes and figure out where to put links to the page.