Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-1588: upgrade HDRP API in tests #992

Merged
merged 1 commit into from
May 29, 2024

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented May 10, 2024

Purpose of this PR

Fix this:
image

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

@glabute glabute requested a review from AntoineCharton May 10, 2024 12:19
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.83%. Comparing base (aeae03b) to head (6e6cc11).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #992   +/-   ##
=======================================
  Coverage   26.83%   26.83%           
=======================================
  Files         249      249           
  Lines       27999    27999           
=======================================
  Hits         7513     7513           
  Misses      20486    20486           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AntoineCharton AntoineCharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thank you!

@glabute glabute merged commit 6828a18 into main May 29, 2024
7 of 9 checks passed
@glabute glabute deleted the dev/tests-hdrp-obsolete-using-api branch May 29, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants