Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMCL-1360: framingtransposer dead zone drift cm2 #1030

Merged
merged 1 commit into from
Jan 8, 2025
Merged

CMCL-1360: framingtransposer dead zone drift cm2 #1030

merged 1 commit into from
Jan 8, 2025

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented Dec 19, 2024 •
edited
Loading

Purpose of this PR

CMCL-1630: FramingTransposer camera drift when nonzero dead zone.
Fix was to improve precision of calculation.

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

low

@glabute glabute requested a review from alexzaranek January 7, 2025 15:15
alexzaranek
alexzaranek approved these changes Jan 7, 2025
View reviewed changes
Copy link

@alexzaranek alexzaranek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Not a big deal, but it seems like the linked Jira ticket is not referencing the correct issue.

@glabute glabute merged commit a3baf7b into release/2.10 Jan 8, 2025
62 of 67 checks passed
@glabute glabute deleted the dev/framingtransposer-dead-zone-drift-cm2 branch January 8, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexzaranek alexzaranek alexzaranek approved these changes

@sebastienduverne sebastienduverne Awaiting requested review from sebastienduverne sebastienduverne is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glabute @alexzaranek