-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMCL-0000: Camera selection bugfixes and various tweaks #1014
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1014 +/- ##
=======================================
Coverage 26.96% 26.96%
=======================================
Files 254 254
Lines 28419 28425 +6
=======================================
+ Hits 7664 7666 +2
- Misses 20755 20759 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A. Reproduced issue on main branch with Sequencer and State Driven components. Confirmed fix for issues on both components. No additional issues found.
B. Compared CameraRig component the Inspector. Changes confirmed. No issues found.
C. Compared CinemachineSplineRoll and LookAtTargetsOnSpline components in the Inspector. Changes confirmed. No issues found.
D. Compared Cinemachine Camera component in the Inspector. No visible change. No issues found.
E. Verified all 3D Samples. Work as expected. No regression found.
F. Compared jumping in place, walking & running animations. No noticeable change. Jump transition looks smooth to me.
Conclusion: no issues found, tested all 3D Samples. Approved!
Purpose of this PR
This is a bag with a bunch of small things.
A. Undo problem with child camera selectors in Sequencer and State Driven Camera:
B. Add CinemachineVirtualCameraBaseEditor as default editors for CInemachineVirtualCameraBase, and make our custom inspectors inherit from it. This improves the quality of inspectors for client-authored cameras and managers (e.g. see the improved inspector for the custom CameraRig in the ThirdPersonWithAimMode sample).
C. Improved inspectors and user manual for CinemachineSplineRoll and LookAtTargetsOnSpline
D. Minor layout tweaks in inspectors: spacings and column alignment, mostly.
E. Added concept of State to SimplePlayerAnimator.cs in the sample code. This is not currently used, but is just future-proofing.
F: Minor tweaking of blend times (into and out of jumping) in the animation controller. This is part of the sample assets.
Testing status
Documentation status
Technical risk
low