Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-0000: Scene view tools cleanup #1003

Merged
merged 7 commits into from
May 30, 2024
Merged

CMCL-0000: Scene view tools cleanup #1003

merged 7 commits into from
May 30, 2024

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented May 30, 2024

Purpose of this PR

Scene view tools was overly complicated to support CM's old hidden game object architecture.
This PR removes all that and simplifies the code.

Scene view tools should work exactly the same as before.
Legacy CM2 components no longer support scene view tools.

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

@glabute glabute requested a review from AntoineCharton May 30, 2024 14:26
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

Codecov Report

Attention: Patch coverage is 1.30719% with 151 lines in your changes are missing coverage. Please review.

Project coverage is 26.90%. Comparing base (cedfb6c) to head (3c04541).
Report is 3 commits behind head on main.

Files Patch % Lines
...e/Editor/Editors/CinemachineOrbitalFollowEditor.cs 0.00% 60 Missing ⚠️
...ditor/Editors/CinemachinePositionComposerEditor.cs 0.00% 20 Missing ⚠️
...itor/Editors/CinemachineThirdPersonFollowEditor.cs 0.00% 20 Missing ⚠️
...emachine/Editor/Editors/CinemachineCameraEditor.cs 11.11% 16 Missing ⚠️
...emachine/Editor/Editors/CinemachineFollowEditor.cs 0.00% 8 Missing ⚠️
...hine/Editor/Editors/CinemachineHardLookAtEditor.cs 0.00% 8 Missing ⚠️
...ditor/Editors/CinemachineRotationComposerEditor.cs 0.00% 8 Missing ⚠️
...ity.cinemachine/Editor/Obsolete/CinemachineTool.cs 0.00% 5 Missing ⚠️
...hine/Editor/Editors/CinemachineSplineRollEditor.cs 0.00% 3 Missing ⚠️
...hine/Editor/Utility/CinemachineSceneToolHelpers.cs 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1003      +/-   ##
==========================================
+ Coverage   26.80%   26.90%   +0.10%     
==========================================
  Files         249      249              
  Lines       28215    27950     -265     
==========================================
- Hits         7562     7520      -42     
+ Misses      20653    20430     -223     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AntoineCharton
Copy link
Contributor

Screenshot 2024-05-30 at 2 26 49 PM

Copy link
Contributor

@AntoineCharton AntoineCharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wait to see if the doc is green but the feature works.

@glabute glabute merged commit e07f5ad into main May 30, 2024
9 checks passed
@glabute glabute deleted the dev/tools-cleanup branch May 30, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants