Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-0000: Add a simple test to ensure spline cart is working correctly #1002

Merged
merged 2 commits into from
May 30, 2024

Conversation

AntoineCharton
Copy link
Contributor

@AntoineCharton AntoineCharton commented May 29, 2024

Purpose of this PR

Make sure we have minimal coverage on spline Cart component

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

None unit test

Technical risk

None

Comments to reviewers

Had a non intrusive tests that checks Spline Cart is minimally working.

@AntoineCharton AntoineCharton requested a review from glabute as a code owner May 29, 2024 19:37
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.05%. Comparing base (cedfb6c) to head (8c84cdd).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1002      +/-   ##
==========================================
+ Coverage   26.80%   27.05%   +0.25%     
==========================================
  Files         249      250       +1     
  Lines       28215    28235      +20     
==========================================
+ Hits         7562     7639      +77     
+ Misses      20653    20596      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glabute glabute merged commit 155139f into main May 30, 2024
9 checks passed
@glabute glabute deleted the dev/unit-test-spline-cart branch May 30, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants