improve the last commit - we don't want object upgrades happening fro…

…m prefab inspectors
Unity-Technologies · May 13, 2024 · 7c09510 · 7c09510
1 parent 9c29a83
commit 7c09510
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/com.unity.cinemachine/Editor/Upgrader/CinemachineUpgradeManager.cs b/com.unity.cinemachine/Editor/Upgrader/CinemachineUpgradeManager.cs
@@ -178,7 +178,7 @@ public static bool ObjectsUsePrefabs(UnityEngine.Object[] objects)
                     if (b != null)
                         go = b.gameObject;
                 }
-                if (go != null && (PrefabUtility.IsPartOfPrefabInstance(go) || PrefabStageUtility.GetCurrentPrefabStage() != null))
+                if (go != null && PrefabUtility.IsPartOfPrefabInstance(go) || PrefabUtility.IsPartOfPrefabAsset(go))
                     return true;
             }
             return false;

diff --git a/com.unity.cinemachine/Editor/Upgrader/UpgradeManagerInspectorHelpers.cs b/com.unity.cinemachine/Editor/Upgrader/UpgradeManagerInspectorHelpers.cs
@@ -3,6 +3,7 @@
 using UnityEditor;
 using System;
 using UnityEngine.UIElements;
+using UnityEditor.SceneManagement;
 
 namespace Unity.Cinemachine.Editor
 {
@@ -88,7 +89,7 @@ public override void OnOpen()
                 }) { 
                     text = text, 
                     style = { flexGrow = 0, alignSelf = Align.Center } 
-                }).SetEnabled(!CinemachineUpgradeManager.ObjectsUsePrefabs(Editor.targets));
+                }).SetEnabled(PrefabStageUtility.GetCurrentPrefabStage() == null && !CinemachineUpgradeManager.ObjectsUsePrefabs(Editor.targets));
 
                 // Upgrade current scene
                 ux.AddChild(new TextElement()
@@ -105,7 +106,7 @@ public override void OnOpen()
                 }) { 
                     text = "Upgrade all objects in Scene", 
                     style = { flexGrow = 0, alignSelf = Align.Center } 
-                }).SetEnabled(!CinemachineUpgradeManager.CurrentSceneUsesPrefabs());
+                }).SetEnabled(PrefabStageUtility.GetCurrentPrefabStage() == null && !CinemachineUpgradeManager.CurrentSceneUsesPrefabs());
 
                 // Upgrade project
                 ux.AddChild(new TextElement()