Bugfix: FramingTransposer with a dead zone would sometimes drift (#1031)

Unity-Technologies · Jan 8, 2025 · 0cb1aa8 · 0cb1aa8
1 parent d28cada
commit 0cb1aa8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/com.unity.cinemachine/CHANGELOG.md b/com.unity.cinemachine/CHANGELOG.md
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### Bugfixes
 - CameraDeactivated events were not sent consistently when a blend interrupted another blend before completion.
 - CameraActivated events were not sent consistently when activation was due to timeline blends.
+- Bugfix: FramingTransposer with a dead zone would sometimes drift.
 
 ### Changed
 - Added delayed processing to near and far clip plane inspector fields for the CinemachineCamera lens.

diff --git a/com.unity.cinemachine/Runtime/Components/CinemachinePositionComposer.cs b/com.unity.cinemachine/Runtime/Components/CinemachinePositionComposer.cs
@@ -319,7 +319,7 @@ public override void MutateCameraState(ref CameraState curState, float deltaTime
                         realTargetPos - cameraOffset, hardGuideOrtho);
                 }
             }
-            curState.RawPosition = localToWorld * (cameraPos + cameraOffset);
+            curState.RawPosition = camPosWorld + localToWorld * cameraOffset;
             m_PreviousCameraPosition = curState.RawPosition;
 
             m_InheritingPosition = false;

diff --git a/com.unity.cinemachine/Runtime/Deprecated/CinemachineFramingTransposer.cs b/com.unity.cinemachine/Runtime/Deprecated/CinemachineFramingTransposer.cs
@@ -549,7 +549,7 @@ public override void MutateCameraState(ref CameraState curState, float deltaTime
                         realTargetPos - cameraOffset, hardGuideOrtho);
                 }
             }
-            curState.RawPosition = localToWorld * (cameraPos + cameraOffset);
+            curState.RawPosition = camPosWorld + localToWorld * cameraOffset;
             m_PreviousCameraPosition = curState.RawPosition;
 
             // Adjust lens for group framing