Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable ros2 launch endpoint.py #164

Open
wants to merge 2 commits into
base: dev-ros2
Choose a base branch
from

Conversation

kimushun1101
Copy link

Proposed change(s)

A Launch file could not be executed by ros2 launch unless the file name contained the word "launch".
It is recommended to change the file name to include "_launch" for the sake of readability.

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

https://docs.ros.org/en/humble/Tutorials/Intermediate/Launch/Creating-Launch-Files.html

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe)

Testing and Verification

colcon build and source install/local_setup.bash, then ros2 launch ros_tcp_endpoint endpoint_launch.py

Test Configuration:

  • Unity Version: Unity 2020.3.16f1
  • Unity machine OS + version: Windows 10
  • ROS machine OS + version: Ubuntu 22.04, ROS Humble
  • ROS–Unity communication: wifi access point local network

Checklist

  • Ensured this PR is up-to-date with the dev branch
  • Created this PR to target the dev branch
  • Followed the style guidelines as described in the Contribution Guidelines
  • Added tests that prove my fix is effective or that my feature works
  • Updated the Changelog and described changes in the Unreleased section
  • Updated the documentation as appropriate

Other comments

A solution to #146 is also recommended.

@unity-cla-assistant
Copy link

unity-cla-assistant commented May 11, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants