Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue390 #391

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Issue390 #391

merged 3 commits into from
Apr 15, 2024

Conversation

theBoEffect
Copy link
Member

@theBoEffect theBoEffect commented Apr 14, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes #390

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.

  • Test A - tested the fix using standard length permission of 8000 kb and then 10kb to force x-access-url in the token
  • Test B - ensured the my/organization endpoint worked and the validation endpoint worked

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README, OpenAPI/Swagger, etc.)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Bo Motlagh added 2 commits April 14, 2024 13:04
@theBoEffect theBoEffect merged commit afa7f1d into master Apr 15, 2024
3 checks passed
@theBoEffect theBoEffect deleted the issue390 branch May 19, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

permission aggregation when x-access-url is provided in the token is not working.
1 participant