Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added is_connected to readonly fields #653

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

alimaktabi
Copy link
Collaborator

@alimaktabi alimaktabi commented Oct 31, 2024

Summary by Sourcery

Enhancements:

  • Add 'is_connected' to the list of read-only fields in the TelegramConnectionSerializer.

Copy link
Contributor

sourcery-ai bot commented Oct 31, 2024

Reviewer's Guide by Sourcery

The PR adds 'is_connected' to the read-only fields in the TelegramConnectionSerializer, preventing this field from being modified through API requests while still allowing it to be included in responses.

Updated class diagram for TelegramConnectionSerializer

classDiagram
    class TelegramConnectionSerializer {
        +created_on
        +pk
        +user_profile
        +title
        +is_connected
    }
    note for TelegramConnectionSerializer "'is_connected' added to read-only fields"
Loading

File-Level Changes

Change Details Files
Added 'is_connected' field to read-only fields in the Telegram connection serializer
  • Added 'is_connected' to read_only_fields list
  • Reformatted the read_only_fields declaration from multiple lines to a single line
telegram/serializers.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alimaktabi - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@alimaktabi alimaktabi merged commit e9f5f5d into develop Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant