-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/telegram/implementation #651
Conversation
Reviewer's Guide by SourceryThis PR makes minor text formatting improvements to the About message and updates the GasTap stats display to show token amounts with proper decimal places and symbols. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @alimaktabi - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -10,7 +10,7 @@ | |||
|
|||
{% for faucet in faucets %} | |||
🔵 *{{ faucet.chain.chain_name }}* | |||
Max Claim Amount: {{ faucet.max_claim_amount }} | |||
Max Claim Amount: {{ faucet.max_claim_amount / (10 ** faucet.chain.decimals) }} {{ faucet.chain.symbol }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider moving the decimal calculation to the business logic layer rather than performing it in the template
Template files should focus on presentation. Computing the formatted amount before rendering would improve maintainability and make edge cases easier to handle.
Max Claim Amount: {{ faucet.formatted_max_claim_amount }} {{ faucet.chain.symbol }}
Summary by Sourcery
Enhance the Telegram bot messages by improving the formatting of the 'about' message and fixing the unit conversion for the maximum claim amount in the 'gastap_stats' message.
Bug Fixes:
Enhancements: