Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #648

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Develop #648

merged 2 commits into from
Oct 26, 2024

Conversation

alimaktabi
Copy link
Collaborator

@alimaktabi alimaktabi commented Oct 26, 2024

Summary by Sourcery

Enhance message formatting and fix capitalization in Telegram bot messages for improved consistency and readability.

Bug Fixes:

  • Correct the capitalization of 'One Time' in the 'gastap_stats' message for consistency.

Enhancements:

  • Standardize bullet point formatting in the 'about' message for consistency.

Copy link
Contributor

sourcery-ai bot commented Oct 26, 2024

Reviewer's Guide by Sourcery

This PR contains minor text formatting changes in two message template files. The changes include adjusting bullet point formatting in the about message and modifying text formatting in the GasTap stats display.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated bullet point formatting in the about message
  • Added escape characters to bullet point dashes to ensure proper markdown rendering
telegram/messages/about.py
Modified text formatting in GasTap stats display
  • Changed 'One-time' to 'One Time' in claim availability text
  • Removed redundant horizontal separator line between faucet entries
telegram/messages/gastap_stats.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@alimaktabi alimaktabi merged commit 16e62d9 into main Oct 26, 2024
2 of 3 checks passed
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alimaktabi - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider keeping the horizontal rule separator between faucet entries to maintain visual clarity when multiple faucets are listed
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -11,7 +11,7 @@
{% for faucet in faucets %}
🔵 *{{ faucet.chain.chain_name }}*
Max Claim Amount: {{ faucet.max_claim_amount }}
Available for: {% if faucet.is_one_time_claim %}One-time{% else %}Weekly{% endif %}
Available for: {% if faucet.is_one_time_claim %}One Time{% else %}Weekly{% endif %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (typo): Use hyphenated form 'One-time' when used as a compound modifier

Suggested change
Available for: {% if faucet.is_one_time_claim %}One Time{% else %}Weekly{% endif %}
Available for: {% if faucet.is_one_time_claim %}One-time{% else %}Weekly{% endif %}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant