Develop

[alimaktabi]

Summary by Sourcery

Simplify constraint verification classes by removing unnecessary constructor methods and correct a typo in a class name within the Twitter constraints module.

Enhancements:

• Remove redundant constructor methods from multiple constraint verification classes across various modules, simplifying the class definitions.
• Correct a typo in the class name from 'IsFollowinTwitterUser' to 'IsFollowingTwitterUser' in the Twitter constraints module.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request primarily focuses on refactoring constraint verification classes across multiple files in the core/constraints directory. The main changes involve removing redundant init methods and fixing a typo in a class name.

File-Level Changes

Change	Details	Files
Removed redundant init methods from constraint verification classes	Deleted init methods that only called super().init(user_profile) Removed unnecessary inheritance of user_profile parameter	core/constraints/farcaster.py core/constraints/lens.py core/constraints/twitter.py core/constraints/general.py core/constraints/arbitrum.py core/constraints/gitcoin_passport.py core/constraints/optimism.py core/constraints/ens.py core/constraints/octant.py
Fixed typo in class name and corresponding references	Renamed 'IsFollowinTwitterUser' to 'IsFollowingTwitterUser' Updated reference in core/models.py to use the corrected class name	core/constraints/twitter.py core/models.py
Modified init method in HasMuonNode class	Added optional 'obj' parameter to init method Updated super().init() call to include the new 'obj' parameter	core/constraints/muon_node.py

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @alimaktabi - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider explaining why the HasMuonNode class retains a custom __init__ method while it was removed from other classes. If possible, align it with the pattern used in other classes for consistency.

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

suggestion: Removal of redundant init methods improves code clarity

This change removes redundant init methods across multiple classes. It's a good optimization that reduces code duplication and improves maintainability. Ensure that this pattern is applied consistently across all relevant classes.

class BridgeEthToArb(ConstraintVerification):
    app_name = ConstraintApp.ARBITRUM.value

    def is_observed(self, *args, **kwargs) -> bool:

[sourcery-ai]

suggestion (typo): Fixed typo in class name IsFollowingTwitterUser

Good catch on fixing the typo in the class name. This improves code consistency and readability.